Pārlūkot izejas kodu

Preserve legacy static effect alias

Paul Klumpp 2 nedēļas atpakaļ
vecāks
revīzija
a34a9859d2
2 mainītis faili ar 16 papildinājumiem un 3 dzēšanām
  1. 3 0
      internal/rgb/impact80.go
  2. 13 3
      internal/rgb/impact80_test.go

+ 3 - 0
internal/rgb/impact80.go

@@ -218,6 +218,9 @@ func Impact80EffectName(value uint8) string {
 }
 
 func ParseImpact80Effect(name string) (uint8, error) {
+	if name == "static" {
+		return 5, nil
+	}
 	targets, _, err := ResolveEffect(name, []Zone{ZoneLogo})
 	if err != nil {
 		return 0, err

+ 13 - 3
internal/rgb/impact80_test.go

@@ -108,10 +108,10 @@ func TestImpact80BacklightCatalog(t *testing.T) {
 		"starlight_dual_sat",
 		"riverflow",
 	}
+	if len(want) != 46 {
+		t.Fatalf("Backlight catalog fixture has %d entries, want 46", len(want))
+	}
 	for id, name := range want {
-		if id > 45 {
-			t.Fatalf("test catalog has %d entries", len(want))
-		}
 		if got := EffectName(ZoneBacklight, uint8(id)); got != name {
 			t.Errorf("EffectName(%q, %d) = %q, want %q", ZoneBacklight, id, got, name)
 		}
@@ -303,3 +303,13 @@ func TestResolveEffectInvalidZone(t *testing.T) {
 		t.Fatal("ResolveEffect() expected error, got nil")
 	}
 }
+
+func TestParseImpact80EffectStaticAlias(t *testing.T) {
+	got, err := ParseImpact80Effect("static")
+	if err != nil {
+		t.Fatalf("ParseImpact80Effect(%q) unexpected error: %v", "static", err)
+	}
+	if got != 5 {
+		t.Errorf("ParseImpact80Effect(%q) = %d, want %d", "static", got, 5)
+	}
+}